bjgf issueshttps://gitlab.bluej.org/bluej/bjgf/-/issues2018-05-16T09:04:42Zhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1971[GREENFOOT-636] Convert about dialog to JavaFX2018-05-16T09:04:42ZNeil Brown[GREENFOOT-636] Convert about dialog to JavaFXCurrently, Greenfoot has its own Swing about dialog in greenfoot.gui.GreenfootAboutDialog. Since we would need to rewrite this into JavaFX, we may as well just delete it, and change bluej.pkgmgr.AboutBlueJ to be a shared AboutDialog cla...Currently, Greenfoot has its own Swing about dialog in greenfoot.gui.GreenfootAboutDialog. Since we would need to rewrite this into JavaFX, we may as well just delete it, and change bluej.pkgmgr.AboutBlueJ to be a shared AboutDialog class which takes the appropriate parameters for software title, website URL, and image name. I think even though they have some differences, parameterising is still better than maintaining two separate about dialogs.
(Something to perhaps discuss among the group at the time: Amjad and I did wonder in the past about having a fold-out section in the dialog showing previous team members, and translators, as a way to reward the translators. This should be fairly easy using JavaFX's TitledPane if we decide we want it.)
---
**Issue metadata**
- Issue type: Task
- Priority: MediumHamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/1970[GREENFOOT-635] Convert class diagram to JavaFX2018-05-21T16:59:28ZNeil Brown[GREENFOOT-635] Convert class diagram to JavaFXThe new class diagram has already been started, in the greenfoot.guifx.ClassDiagram class. It needs more work though, to replicate the original class diagram, both in terms of graphical appearance, and because some of the context menu i...The new class diagram has already been started, in the greenfoot.guifx.ClassDiagram class. It needs more work though, to replicate the original class diagram, both in terms of graphical appearance, and because some of the context menu items (like Delete, Convert to Stride/Java) are missing from the class actions. Be careful to cover all five main cases in this dialog:
- The World class
- Subclasses of World
- The Actor class
- Subclasses of Actor
- Non World/Actor classes.
While converting this, it would be good to also tackle http://bugs.bluej.org/browse/GREENFOOT-599
Also make sure to test what happens if there are two many classes (should get a vertical scroll), and if there are classes with a deeply nested hierarchy and/or long names (probably, we need a horizontal scroll at some point, but don't let it appear too eagerly.)
---
**Issue metadata**
- Issue type: Task
- Priority: MediumNeil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1969[GREENFOOT-634] Convert set-image dialog2018-05-16T09:09:15ZNeil Brown[GREENFOOT-634] Convert set-image dialogThe set-image dialog currently lives in greenfoot.gui.images (move to *.guifx.* as you convert). Bear in mind that this dialog has twin uses: setting the image for an existing class, and creating a new class with a specified image.
W...The set-image dialog currently lives in greenfoot.gui.images (move to *.guifx.* as you convert). Bear in mind that this dialog has twin uses: setting the image for an existing class, and creating a new class with a specified image.
With hindsight, I'm not totally sold on the cog menu in this dialog, so I think there's some room for improvement. One change we could make is that we don't currently have a right-click menu for images. The Edit, Duplicate and Delete items on the cog menu could be moved to a context menu, and the Create, Paste and Import could perhaps go back to being buttons. (Or we could put a name for the menu rather than a cog?)
Don't forget to swap uses of GClass to ClassTarget.
Update: there is now a GreenfootStage.setImageFor method which is wired up to the context menu. So the invocation of the converted set-image dialog should go in that method.
---
**Issue metadata**
- Issue type: Task
- Priority: MediumAmjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1968[GREENFOOT-633] Convert export dialog to JavaFX2018-05-16T09:01:02ZNeil Brown[GREENFOOT-633] Convert export dialog to JavaFXThis currently lives in greenfoot.gui.export (move to *.guifx.* as you convert). Of all the GUI items being converted, I feel this one probably has some scope for improvement, but see what you think. All the Swing invokeLaters in Expor...This currently lives in greenfoot.gui.export (move to *.guifx.* as you convert). Of all the GUI items being converted, I feel this one probably has some scope for improvement, but see what you think. All the Swing invokeLaters in Exporter will need to become Platform.runLater, but I think otherwise the threading is actually straightforward. Also convert use of GProject to Project.
The properties file code involved in the export will need to be adjusted but I may do that as part of my imminent fix to properties (should be finished 8/12/17 or so).
We may not want to convert the "Export to web page" given that it uses applets. Perhaps something to discuss once someone starts on this.
---
**Issue metadata**
- Issue type: Task
- Priority: MediumAmjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1967[GREENFOOT-632] Convert Sound Recorder to JavaFX2018-05-16T09:05:34ZNeil Brown[GREENFOOT-632] Convert Sound Recorder to JavaFXThis lives in the greenfoot.gui.soundrecorder package (move to greenfoot.guifx.soundrecorder as you convert). I think you will probably need a Canvas or an ImageView+WritableImage to convert SoundPanel to FX. Also just watch out for th...This lives in the greenfoot.gui.soundrecorder package (move to greenfoot.guifx.soundrecorder as you convert). I think you will probably need a Canvas or an ImageView+WritableImage to convert SoundPanel to FX. Also just watch out for the Swing timer task, which will need converting to FX: I think an Animation/Timeline is probably the right FX equivalent. Finally, swap the use of GProject to simply Project
---
**Issue metadata**
- Issue type: Task
- Priority: MediumAmjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1966[GREENFOOT-631] Recompile/Reset while an Inspector is opened throws wrong-thr...2018-05-04T15:26:12ZAmjad Altadmri[GREENFOOT-631] Recompile/Reset while an Inspector is opened throws wrong-thread exception- Create an actor
- open the object inspector for that actor
- Reset or change the code and recompile while having the object inspector still open
This will throw an exception: java.lang.IllegalStateException: Not on FX application th...- Create an actor
- open the object inspector for that actor
- Reset or change the code and recompile while having the object inspector still open
This will throw an exception: java.lang.IllegalStateException: Not on FX application thread
Tested on Mac and Windows.
In BlueJ / former Greenfoot-versions the object inspector is / was closed when the code was compiled. I guess this is the way it should be.
Reported by Thomas Karp.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Amjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1965[GREENFOOT-630] Greenfoot display problem on 4k resolution screen2018-05-03T15:09:10ZHamza Hamza[GREENFOOT-630] Greenfoot display problem on 4k resolution screenThis is reported by the user: When having a 4k resolution, Greenfoot is so small that it can be hard to read, the editor also is only about half the size of the window that opened and the rest is just plain white.
---
**Issue metadata*...This is reported by the user: When having a 4k resolution, Greenfoot is so small that it can be hard to read, the editor also is only about half the size of the window that opened and the rest is just plain white.
---
**Issue metadata**
- Issue type: Bug
- Priority: High
- Fix versions: 3.5.0Amjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1964[GREENFOOT-629] Autocompilation stops working2018-05-10T17:05:31ZDavin McCall[GREENFOOT-629] Autocompilation stops workingIt's been reported by a number of users that auto-compilation stops working occasionally. Eg see:
https://www.greenfoot.org/topics/59642/0
It seems likely that the major re-work necessary for the next major Greenfoot release will f...It's been reported by a number of users that auto-compilation stops working occasionally. Eg see:
https://www.greenfoot.org/topics/59642/0
It seems likely that the major re-work necessary for the next major Greenfoot release will fix this by-the-way, but if we can get a reliable way to reproduce the issue then we should test before release.
Workaround is to re-start Greenfoot.
---
**Issue metadata**
- Issue type: Bug
- Priority: MediumDavin McCallDavin McCallhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1963[GREENFOOT-628] Save the World doesn't always lead to new code being executed2018-06-19T15:53:19ZNeil Brown[GREENFOOT-628] Save the World doesn't always lead to new code being executedIf you save the world, sometimes when the world recompiles and initialises, it still uses the old class, even after a reset, until you make a change which forces a second compile. May get solved in post-3.1.0 rewrite anyway.
---
**Iss...If you save the world, sometimes when the world recompiles and initialises, it still uses the old class, even after a reset, until you make a change which forces a second compile. May get solved in post-3.1.0 rewrite anyway.
---
**Issue metadata**
- Issue type: Bug
- Priority: MediumDavin McCallDavin McCallhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1962[GREENFOOT-627] Put a picture of the current actor as an overlay in top right...2018-03-23T10:46:52ZNeil Brown[GREENFOOT-627] Put a picture of the current actor as an overlay in top right of the editorStudents often forget or get mixed up as to which actor they're editing. We could solve this by overlaying the image of the actor (semi-transparent graphically, mouse transparent) in the top right of the class editor window (either only ...Students often forget or get mixed up as to which actor they're editing. We could solve this by overlaying the image of the actor (semi-transparent graphically, mouse transparent) in the top right of the class editor window (either only top-right, or floating top-right as you scroll).
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1961[GREENFOOT-626] Opening already-extracted gfar fails and prints stack trace2018-05-17T15:47:16ZDavin McCall[GREENFOOT-626] Opening already-extracted gfar fails and prints stack traceOpening an already-extracted gfar fails and prints the following stack trace:
{code}
Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
at bluej.utility.Utility.lambda$maybeExtractArchive$4(Utility.java:...Opening an already-extracted gfar fails and prints the following stack trace:
{code}
Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
at bluej.utility.Utility.lambda$maybeExtractArchive$4(Utility.java:950)
at com.sun.javafx.application.PlatformImpl.lambda$null$173(PlatformImpl.java:295)
at java.security.AccessController.doPrivileged(Native Method)
at com.sun.javafx.application.PlatformImpl.lambda$runLater$174(PlatformImpl.java:294)
at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
at com.sun.glass.ui.gtk.GtkApplication.lambda$null$49(GtkApplication.java:139)
at java.lang.Thread.run(Thread.java:745)
{code}
---
**Issue metadata**
- Issue type: Bug
- Priority: MediumHamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/1960[GREENFOOT-625] Auto-complete causes showing wrong compile errors2018-06-22T12:05:52ZNeil Brown[GREENFOOT-625] Auto-complete causes showing wrong compile errorsWhen using auto-complete (with Strg + space) I get errors. E.g. I write
{{this.abc = abc}}
The first abc is marked as error, the message is: cannot find symbol - variable ab
Two examples can be found here:
https://www.youtube.c...When using auto-complete (with Strg + space) I get errors. E.g. I write
{{this.abc = abc}}
The first abc is marked as error, the message is: cannot find symbol - variable ab
Two examples can be found here:
https://www.youtube.com/watch?v=jmh06-pNMMs&t=11m40s
https://www.youtube.com/watch?v=jmh06-pNMMs&t=18m6s
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1959[GREENFOOT-624] Classes in varying order in class diagram2017-12-12T14:50:40ZMichael Kölling[GREENFOOT-624] Classes in varying order in class diagramThe list of Actor subclasses (and possibly 'Other classes' - have not tested that) is in a somewhat non-deterministic order. When a class is created, it is put at the end. After re-open, it is at some random location.
Arrange the clas...The list of Actor subclasses (and possibly 'Other classes' - have not tested that) is in a somewhat non-deterministic order. When a class is created, it is put at the end. After re-open, it is at some random location.
Arrange the classes so that they are always alphabetical.
---
**Issue metadata**
- Issue type: Bug
- Priority: Low
- Fix versions: 3.5.0Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1958[GREENFOOT-623] Greenfoot - Paste is doubled in the search box on Mac2018-09-11T13:47:20ZAmjad Altadmri[GREENFOOT-623] Greenfoot - Paste is doubled in the search box on MacMac: when using the search box in the class codes (Ctrl+F), pasting something into it (Ctrl+V) always pastes it twice.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Mac: when using the search box in the class codes (Ctrl+F), pasting something into it (Ctrl+V) always pastes it twice.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1957[GREENFOOT-622] Editor key bindings cannot be changed2018-05-24T14:13:56ZDavin McCall[GREENFOOT-622] Editor key bindings cannot be changedIn the preferences, the Editor key bindings pane doesn't work correctly. If you choose an action and press "add key", then:
* on linux, no key that you press seems to be detected
* on Mac OS X, pressing a modifier key seems to be det...In the preferences, the Editor key bindings pane doesn't work correctly. If you choose an action and press "add key", then:
* on linux, no key that you press seems to be detected
* on Mac OS X, pressing a modifier key seems to be detected as a complete key. So for instance pressing "cmd" instantly sets the key as "cmd+unknown keycode (0x300)" (despite that a second key was not yet pressed).
Should check this for BlueJ 4.0 as well; not sure if it is also an issue there.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Amjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1956[GREENFOOT-621] ScoreBoard has a compilation error2017-02-27T14:53:18ZAmjad Altadmri[GREENFOOT-621] ScoreBoard has a compilation error
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Amjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1955[GREENFOOT-620] GreenfootImage constructor throws NPE when it shouldn't2017-02-06T18:13:05ZNeil Brown[GREENFOOT-620] GreenfootImage constructor throws NPE when it shouldn'tGreenfootImage has constructors that say they should be able to accept null, but in the change to greenfoot.Color a bug was introduced such that they throw an NPE instead of accepting the parameter.
---
**Issue metadata**
- Issue type...GreenfootImage has constructors that say they should be able to accept null, but in the change to greenfoot.Color a bug was introduced such that they throw an NPE instead of accepting the parameter.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.0Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1954[GREENFOOT-619] Implement possibility to update to 3.0.0-API automatically (e...2021-05-02T19:15:01ZNeil Brown[GREENFOOT-619] Implement possibility to update to 3.0.0-API automatically (even if clicked away the first time)When you open an 3.0.x-scenario with 3.1 you are prompted with the question if you want to automatically update to the 3.0.0-API. If you click "no, I will updated later manually" you never will get the possibility to update automatically...When you open an 3.0.x-scenario with 3.1 you are prompted with the question if you want to automatically update to the 3.0.0-API. If you click "no, I will updated later manually" you never will get the possibility to update automatically (at least I was not able to find it). This is very annoying if you have a lot of classes which you have to update manually. I think a lot of teachers have a lot of scenarios which they want to update comfortably.
As the 3.x-API shall be pushed by force I would recommend to open the dialog each time the scenario opens. Alternatively add a menu-item.
---
**Issue metadata**
- Issue type: Task
- Priority: Mediumhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1953[GREENFOOT-618] 'Convert Class To Java' can cause exception2018-05-24T14:13:51ZMichael Kölling[GREENFOOT-618] 'Convert Class To Java' can cause exceptionThe 'Convert Class To Java' menu item (from the main menu) can cause an exception when called on a class that is already Java.
Normally, the menu item should be greyed out if the class is Java. The following sequence leaves the item e...The 'Convert Class To Java' menu item (from the main menu) can cause an exception when called on a class that is already Java.
Normally, the menu item should be greyed out if the class is Java. The following sequence leaves the item enabled for a Java class:
- select a Stride class
- select 'Convert to Java'. Confirm.
(Conversion happens, class remains selected; menu item remains enabled.)
- select 'Convert to Java' again.
Possible fix: either disable menu item after conversion, or de-select class after conversion.
---
**Issue metadata**
- Issue type: Bug
- Priority: Lowest
- Fix versions: 3.5.0Amjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1952[GREENFOOT-617] Closing the Terminal will bring the editor to front, even if ...2017-01-29T12:29:26ZAmjad Altadmri[GREENFOOT-617] Closing the Terminal will bring the editor to front, even if the greenfoot main frame was focused before the terminal.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.1.0
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.1.0