bjgf issueshttps://gitlab.bluej.org/bluej/bjgf/-/issues2018-09-18T16:15:30Zhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2116[GREENFOOT-785] "Update project API" dialog is badly layed out2018-09-18T16:15:30ZDavin McCall[GREENFOOT-785] "Update project API" dialog is badly layed outWhen opening a project edited with an older version of Greenfoot, the text in the dialog prompting to automatically update code to the newer API version is badly laid out. See attached image.
---
**Issue metadata**
- Issue type: ...When opening a project edited with an older version of Greenfoot, the text in the dialog prompting to automatically update code to the newer API version is badly laid out. See attached image.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Hamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/2044[GREENFOOT-710] Intermittent bug when removing object from the world class2018-09-18T13:43:18ZHamza Hamza[GREENFOOT-710] Intermittent bug when removing object from the world classThis is a bug reported by one of the Greenfoot teachers. The project that shows the bug is attached. "It is solitaire game Aces Up. One team had a strange intermittent bug where, rarely, calling removeObject() on a Card caused it to be m...This is a bug reported by one of the Greenfoot teachers. The project that shows the bug is attached. "It is solitaire game Aces Up. One team had a strange intermittent bug where, rarely, calling removeObject() on a Card caused it to be moved to (0, 0) rather than disappearing from the world. The removal happens in the method Pile.removeTopCard().
The problem has occurred with Greenfoot 3.1.0 on two different Mac computers, the most recent running OS X El Capitan (10.11.6)"
There is a link of the video showing many successful card removals, followed by an occurrence of the bug [[https://drive.google.com/open?id=1wHtecsmkHHR-SBCWCMtqWI8kmgbTJFE-|https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Fopen%3Fid%3D1wHtecsmkHHR-SBCWCMtqWI8kmgbTJFE-&data=01%7C01%7CHamza.Hamza%40kcl.ac.uk%7C8d6f719ba78042201e1008d5b9c6138a%7C8370cf1416f34c16b83c724071654356%7C0&sdata=Iikq4vz9k9NqtHdfm2t4ew2y9guvrF9o47W8L8Zjr9w%3D&reserved=0]].
The rules for the game is summarised:
* Clicking on the deck deals a card to each of 4 piles.
* A card can be removed from the top of a pile by clicking on it if another card of the same suit and higher rank is at the top of a pile.
* A card can be moved from the top of a pile to an empty pile by dragging it.
* To win the game, the deck must be empty with exactly 1 ace in each pile.
It is also attached in this ticket the screenshot of the bug.
!image.png!
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2129[GREENFOOT-801] Save the World cannot be performed after project open2018-09-18T10:30:52ZNeil Brown[GREENFOOT-801] Save the World cannot be performed after project openIf you open a project, and then immediately try to create some objects and save the world, you are told it is not possible if you Act/Run before Reset. This dialog should not be shown -- loading the project should count as a Reset for t...If you open a project, and then immediately try to create some objects and save the world, you are told it is not possible if you Act/Run before Reset. This dialog should not be shown -- loading the project should count as a Reset for these purposes, and thus Save the World should just work in this case, not give an error.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2126[GREENFOOT-798] Save the World missing from top menu2018-09-18T10:30:27ZNeil Brown[GREENFOOT-798] Save the World missing from top menuAfter our menu rearrangement in 3.5.0, the "Save the World" option is not on the top menu bar in Greenfoot, only on the context menu. I think was accidental, and it should be re-added to the top menu as it helps discoverability, probabl...After our menu rearrangement in 3.5.0, the "Save the World" option is not on the top menu bar in Greenfoot, only on the context menu. I think was accidental, and it should be re-added to the top menu as it helps discoverability, probably under the Tools menu.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2121[GREENFOOT-791] Cannot construct world with constructor arguments more than once2018-09-17T14:45:08ZDavin McCall[GREENFOOT-791] Cannot construct world with constructor arguments more than onceIf a world constructor has parameters, the first construction attempt succeeds, the second fails with "An object with this name already exists".
Edit: this reportedly also occurs for actors.
---
**Issue metadata**
- Issue type...If a world constructor has parameters, the first construction attempt succeeds, the second fails with "An object with this name already exists".
Edit: this reportedly also occurs for actors.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Hamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/2127[GREENFOOT-799] World class in new scenario extends fully-qualified greenfoot...2018-09-14T16:39:56ZNeil Brown[GREENFOOT-799] World class in new scenario extends fully-qualified greenfoot.WorldIf you make a new Java scenario in Greenfoot 3.5.0, the line of code declaring the World class says:
public class MyWorld extends greenfoot.World
That should say:
public class MyWorld extends World
Without the fully qualified...If you make a new Java scenario in Greenfoot 3.5.0, the line of code declaring the World class says:
public class MyWorld extends greenfoot.World
That should say:
public class MyWorld extends World
Without the fully qualified name, as that is confusing. I think this relates to how we make a new class, so we should special case this for greenfoot.* to leave off the greenfoot. import, without breaking the general mechanism for extending fully-qualified names.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1849[GREENFOOT-511] Cannot recover from infinite loop2018-09-14T15:43:01ZMichael Kölling[GREENFOOT-511] Cannot recover from infinite loopWhen an act method goes into an infinite loop, Greenfoot is not able to recover gracefully.
'Pause' does not work then (that's probably acceptable, and technically hard to change, so that's ok), and 'Reset' interrupts execution, but l...When an act method goes into an infinite loop, Greenfoot is not able to recover gracefully.
'Pause' does not work then (that's probably acceptable, and technically hard to change, so that's ok), and 'Reset' interrupts execution, but leaves GF in an odd state where the world cannot be recreated (this needs fixing).
---
**Issue metadata**
- Issue type: Bug
- Priority: High
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2118[GREENFOOT-787] Class diagram not showing inheritance correctly for classes w...2018-09-14T15:42:31ZNeil Brown[GREENFOOT-787] Class diagram not showing inheritance correctly for classes with no sourceAs reported on the Greenroom, if you have classes in a scenario with no source code, they are displayed in the other section in the class diagram, rather than being correctly placed in class hierarchy. This used to work, so it must rela...As reported on the Greenroom, if you have classes in a scenario with no source code, they are displayed in the other section in the class diagram, rather than being correctly placed in class hierarchy. This used to work, so it must relate to a change made in 3.5.0.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Hamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/2122[GREENFOOT-792] Greenfoot inspectors no longer auto-update2018-09-13T16:16:15ZNeil Brown[GREENFOOT-792] Greenfoot inspectors no longer auto-updateIn Greenfoot 3.1.0, inspectors would auto-update (every 500ms) while showing via a TimerTask. This functionality was accidentally removed in 3.5.0, but should be restored (using the FX animation API, most likely).
---
**Issue metadata...In Greenfoot 3.1.0, inspectors would auto-update (every 500ms) while showing via a TimerTask. This functionality was accidentally removed in 3.5.0, but should be restored (using the FX animation API, most likely).
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2115[GREENFOOT-784] Large worlds cause exception2018-09-11T17:54:55ZDavin McCall[GREENFOOT-784] Large worlds cause exceptionWorlds beyond a certain size cause an exception because the inter-VM communications buffer is fixed size (around 10MB I think).
{code}
Exception in thread "Thread-7" java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIn...Worlds beyond a certain size cause an exception because the inter-VM communications buffer is fixed size (around 10MB I think).
{code}
Exception in thread "Thread-7" java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:521)
at java.nio.DirectIntBufferS.put(DirectIntBufferS.java:297)
at greenfoot.vmcomm.VMCommsSimulation.doInterVMComms(VMCommsSimulation.java:364)
at greenfoot.vmcomm.VMCommsSimulation.access$000(VMCommsSimulation.java:51)
at greenfoot.vmcomm.VMCommsSimulation$1.run(VMCommsSimulation.java:172)
{code}
We might want to raise the current size to at least 20MB (which allows 2000x2000 and a little bit larger world size), or have a dynamic size. If we choose to have a fixed limit, whether we increase it from the current or not, there should be a suitable exception (with message) thrown by the world constructor, rather than having this internal failure.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1958[GREENFOOT-623] Greenfoot - Paste is doubled in the search box on Mac2018-09-11T13:47:20ZAmjad Altadmri[GREENFOOT-623] Greenfoot - Paste is doubled in the search box on MacMac: when using the search box in the class codes (Ctrl+F), pasting something into it (Ctrl+V) always pastes it twice.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Mac: when using the search box in the class codes (Ctrl+F), pasting something into it (Ctrl+V) always pastes it twice.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2123[GREENFOOT-793] World not automatically instantiated in new scenario2018-09-11T12:36:09ZNeil Brown[GREENFOOT-793] World not automatically instantiated in new scenarioThis used to happen in 3.1.0 but does not happen in 3.5.0. I believe the reason for the change is that the logic used to be "If only one world, instantiate automatically", but we removed that as it isn't necessarily what is wanted. But...This used to happen in 3.1.0 but does not happen in 3.5.0. I believe the reason for the change is that the logic used to be "If only one world, instantiate automatically", but we removed that as it isn't necessarily what is wanted. But we should cover the new scenario case, probably most easily by setting the lastWorld property in the project file when making a new scenario.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Hamza HamzaHamza Hamzahttps://gitlab.bluej.org/bluej/bjgf/-/issues/2125[GREENFOOT-797] Stop control panel buttons getting focus2018-09-10T18:39:37ZNeil Brown[GREENFOOT-797] Stop control panel buttons getting focusIn the standalone export, the buttons can get focus and this causes issues with keypresses (e.g. space triggers the button, so you cannot listen for space bar in a running scenario). The IDE version avoids this by focusing the world on ...In the standalone export, the buttons can get focus and this causes issues with keypresses (e.g. space triggers the button, so you cannot listen for space bar in a running scenario). The IDE version avoids this by focusing the world on run, but it is still a bit odd because the buttons cannot get focus again. We agreed in the meeting that the simplest fix was just to prevent the buttons (or speed slider) ever getting focus.
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2124[GREENFOOT-796] Mac: Control-click on actor doesn't properly open popup menu2018-09-07T17:01:34ZDavin McCall[GREENFOOT-796] Mac: Control-click on actor doesn't properly open popup menuOn Mac, control+click should act as a right click: on an actor or world it should open the popup menu to allow calling methods interactively. In Greenfoot 3.5.0 this isn't working correctly. (The popup menu doesn't appear, or appears onl...On Mac, control+click should act as a right click: on an actor or world it should open the popup menu to allow calling methods interactively. In Greenfoot 3.5.0 this isn't working correctly. (The popup menu doesn't appear, or appears only briefly).
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2119[GREENFOOT-788] Actor/World documentation does not show (opens blank)2018-08-06T14:31:59ZDavin McCall[GREENFOOT-788] Actor/World documentation does not show (opens blank)The actor/world documentation shows a blank page instead of the actual documentation (the URL is incorrect).
(This is fixed already for the next release).
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versi...The actor/world documentation shows a blank page instead of the actual documentation (the URL is incorrect).
(This is fixed already for the next release).
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Davin McCallDavin McCallhttps://gitlab.bluej.org/bluej/bjgf/-/issues/2114[GREENFOOT-783] Intersection test is not pixel-perfect for rotated objects2018-07-31T17:16:55ZDavin McCall[GREENFOOT-783] Intersection test is not pixel-perfect for rotated objectsIf you have two square actors, both rotated by the same multiple of 90 degrees (but not 0), and they overlap by a single pixel, the {{isTouching}} method fails to see an intersection.
This is the problem described on the greenfoot.org...If you have two square actors, both rotated by the same multiple of 90 degrees (but not 0), and they overlap by a single pixel, the {{isTouching}} method fails to see an intersection.
This is the problem described on the greenfoot.org forum, here: https://www.greenfoot.org/topics/59584/0
---
**Issue metadata**
- Issue type: Bug
- Priority: Medium
- Fix versions: 3.5.1Davin McCallDavin McCallhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1750[GREENFOOT-406] Revamp project.greenfoot management2018-07-27T12:00:05ZNeil Brown[GREENFOOT-406] Revamp project.greenfoot managementThe {{project.greenfoot}} file is changing all the time, even if the project was only recompiled. Also, the entries change their order every time with no recognizable system so that's impossible to track a Greenfoot project with versioni...The {{project.greenfoot}} file is changing all the time, even if the project was only recompiled. Also, the entries change their order every time with no recognizable system so that's impossible to track a Greenfoot project with versioning software like git or SVM (gitignoring the project file breaks Greenfoot as well)
---
**Issue metadata**
- Issue type: Task
- Priority: Low
- Fix versions: 3.5.0Neil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1974[GREENFOOT-639] Convert execution twirler to JavaFX2018-07-27T11:57:37ZNeil Brown[GREENFOOT-639] Convert execution twirler to JavaFXThe old IDE interface had an execution twirler (greenfoot.gui.ExecutionTwirler). This should be converted to JavaFX and added to GreenfootStage, along with adding its usages from the old GreenfootFrame into equivalent code in GreenfootS...The old IDE interface had an execution twirler (greenfoot.gui.ExecutionTwirler). This should be converted to JavaFX and added to GreenfootStage, along with adding its usages from the old GreenfootFrame into equivalent code in GreenfootStage.
---
**Issue metadata**
- Issue type: Task
- Priority: MediumNeil BrownNeil Brownhttps://gitlab.bluej.org/bluej/bjgf/-/issues/1981[GREENFOOT-646] Move the set-player dialog to JavaFX2018-07-27T11:57:11ZNeil Brown[GREENFOOT-646] Move the set-player dialog to JavaFXIf you press Cmd-Shift-P (Ctrl-Shift-P on non-Mac) you get the dialog that lets you set the player name for UserInfo. (This dialog is not very discoverable : there is no menu option for it, but the shortcut is listed in the preferences....If you press Cmd-Shift-P (Ctrl-Shift-P on non-Mac) you get the dialog that lets you set the player name for UserInfo. (This dialog is not very discoverable : there is no menu option for it, but the shortcut is listed in the preferences.)
---
**Issue metadata**
- Issue type: Task
- Priority: MediumAmjad AltadmriAmjad Altadmrihttps://gitlab.bluej.org/bluej/bjgf/-/issues/1984[GREENFOOT-649] Preferences menu item in edit menu must be converted (non Mac)2018-07-27T11:55:20ZDavin McCall[GREENFOOT-649] Preferences menu item in edit menu must be converted (non Mac)The preferences menu item is not yet in the JavaFX gui. It should appear for non-Mac only. (For Mac the preferences should be accessible via the application menu).
---
**Issue metadata**
- Issue type: Task
- Priority: MediumThe preferences menu item is not yet in the JavaFX gui. It should appear for non-Mac only. (For Mac the preferences should be accessible via the application menu).
---
**Issue metadata**
- Issue type: Task
- Priority: MediumHamza HamzaHamza Hamza