[GREENFOOT-146] getNeighbours bug

From CKnibbe@comcast.net: {noformat}

I think I have encountered a bug in the getNeighbours method.
 I put a file ?getNeighbours_bug.jar? in the Files area.
 Extract the file ?SavedWorld.txt? from the .jar file.  Make sure it
is in the ?current? directory. (Sorry, I haven?t figured out yet how to open this file as a ?resource?.) 3. Open my scenario (samegame) within Greenfoot. You should see a 13x8 field of colored bricks, with a row of buttons at the bottom. 4. Click ?Run? to start the simulation. 5. Press F6 to enable some internal debugging features. A ladybug icon should appear in the button row. 6. Click on the ladybug, and click on ?Restore World?. This will load a saved world file named ?SavedWorld.txt?. You should now see a field of bricks with about ? of the bricks gone. 7. Click ?Pause?. 8. Right-click on the Green brick at 1,2, and invoke his getNeighbours method with (1, false, Brick.class). getNeighbours returns an ArrayList with 3 elements: Blue 1,3 Yellow 2,0 Yellow 1,1 The following element is missing from the list: Green 2,2 9. Similarly, if you check the getNeighbours of the Blue brick at 1,3, you will see that the list is also missing a brick, the Blue brick at 2,3. 10. Also, if you check the getNeighbours of the Green brick at 1,4, you will see that this list is also missing a brick, the Green brick at 2,4.

Some possibly relevant factoids (or maybe irrelevant!):
 Every time I have noticed this problem, it is a brick to the right
which is not recognized as a neighbour. 2. The unrecognized neighbour is often in column 2. 3. I did not see this problem at all until I increased the size of my game board to at least 11 columns and 8 rows (plus the 9th button row).

Thanks for your help, Clo {noformat}

Issue metadata

Issue type: Bug
Priority: Medium
Fix versions: 1.5.2